Final cleanup add hashlib #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created api/ folder and _v1 with routes Clean up FastAPI app init Modified database init with motor_async Created settings.py Added missing dependencies Deleted NOTICE
Created /schemas route
Clean up SchemaDefinition Added condition for uniqueness of title in schemas_collection
Pull Request Test Coverage Report for Build 20129877451Details
💛 - Coveralls |
Added connect_to_mongo and close_mongo to database.py Added MONGO_URI to settings
Member
Author
|
I will work still on this. I will now implement the |
Deleted id in SchemaDefinition Changed MONGO_URI to str
Added add_schema to api
Added _id resolution in route methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KoeppelSoftwareEngineer please, check the "Files changed" menu above, and see what I did. I am creating now a summary with Copilot, but essentially:
/api/v1. I created specifically the router for different methods (which in our case, will be for manipulatingschemas)settings.pyfile to control better our previosly hardcoded parameters (e.g., the MongoDB localhost port, or the one for CORS)main.pyanddatabase.pymodels/schema_definitions.pySummary by GitHub Copilot
This pull request refactors the backend architecture to use FastAPI with async MongoDB access, introduces a new modular API structure, and updates the schema model and configuration management. The legacy synchronous backend code is removed in favor of a new
jsonedpackage, which implements an async API and database layer, centralized settings, and improved project organization.Backend architecture migration:
backend/main.py,backend/database.py,backend/datamodel.py) and replaces them with an async FastAPI app injsoned/main.py, using Motor for MongoDB access and a lifespan event for startup/shutdown logic. [1] [2] [3] [4] [5]API modularization and routing:
jsoned/api/v1, including a main router (api.py), a schemas endpoint (endpoints/schemas.py), and an API router initializer (__init__.py). The schemas endpoint provides an async route for listing all schemas. [1] [2] [3]Database and model updates:
id, atitlefield, and updated typing injsoned/models/schema_definition.py. Database access is now async, and a unique index on thetitlefield is created at startup. [1] [2]Centralized configuration:
jsoned/settings.py) usingpydantic-settingsfor configuration management (project name, API prefix, CORS origins, MongoDB URI).Project structure and dependency updates:
pyproject.tomlto useinboard[fastapi],motor, andpydantic-settings, changes code paths frombackendtojsoned, and moves version file output accordingly. [1] [2] [3]Other cleanup:
NOTICEas those files are no longer present.